Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor cve and product_info Tables #2521

Closed
Matthew-Grayson opened this issue Feb 9, 2024 · 0 comments · Fixed by #2526
Closed

Refactor cve and product_info Tables #2521

Matthew-Grayson opened this issue Feb 9, 2024 · 0 comments · Fixed by #2526
Assignees
@Matthew-Grayson
Labels
Backend ASM-VDB Technical Infrastructure and Database Database Changes to table models. Refactor Restructuring existing computer code without changing its behavior.

Comments

@Matthew-Grayson
Copy link
Contributor

🐛 Summary

These are new tables that don't follow Crossfeed naming conventions. This makes development around the API confusing.
The column names use snake_case whereas the rest of the tables use camelCase. Additionally, the uuid for the cve table is called "cve_uid" whereas every other table uses the name "id".
Here are two tables that follow the naming convention:

Screenshot 2024-02-07 at 14 18 31 Screenshot 2024-02-07 at 14 19 09

Here are the new tables:

Screenshot 2024-02-07 at 14 19 26 Screenshot 2024-02-07 at 14 20 24
@Matthew-Grayson Matthew-Grayson self-assigned this Feb 9, 2024
@Matthew-Grayson Matthew-Grayson added Backend ASM-VDB Technical Infrastructure and Database Database Changes to table models. Refactor Restructuring existing computer code without changing its behavior. labels Feb 9, 2024
@Matthew-Grayson Matthew-Grayson mentioned this issue Feb 9, 2024
Merged
12 tasks
@Matthew-Grayson Matthew-Grayson linked a pull request Feb 12, 2024 that will close this issue
2521 Refactor CVE and Product Info Tables #2526
Merged
12 tasks
@Matthew-Grayson Matthew-Grayson mentioned this issue Feb 17, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Matthew-Grayson Matthew-Grayson

Labels
Backend ASM-VDB Technical Infrastructure and Database Database Changes to table models. Refactor Restructuring existing computer code without changing its behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2521 Refactor CVE and Product Info Tables cisagov/crossfeed
1 participant
@Matthew-Grayson