-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Looking Darkmode + Update Nav button text #180
Closed
Closed
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
be19c3f
Added Potential Errors Section
death7654 9a59652
better dark mode
death7654 127167c
update button function
death7654 c56c8d0
angry text added
death7654 f8c74db
update extra errors section
death7654 00eade1
Better search bar
death7654 d207464
Made Docs more formalish, + markdown formattings
death7654 92ad660
Merge branch 'main' into main
death7654 bb896cc
Merge branch 'chrultrabook:main' into main
death7654 f6113a4
better dark mode
death7654 11d0a01
Better search bar
death7654 1fd2397
better dark mode
death7654 cb556c0
Better search bar
death7654 51a7819
Update CSS Variables to make Dark Mode Darker and Remove Unused Changes
death7654 ef1086e
Update Search Bar In Supported JSON For Better Visuals
death7654 24684b2
Merge branch 'darkmode' of https://github.com/death7654/ChrultrabookD…
death7654 89601eb
Update CSS Variables To Make Dark Mode Darker And Redesign Search bar…
death7654 8f4850e
Merge branch 'darkmode' of https://github.com/death7654/ChrultrabookD…
death7654 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,40 +24,43 @@ | |
--c-brand: #3D50F5; | ||
--c-brand-light: #4e5ff8; | ||
--c-tip: #45d48c; | ||
--c-nav: #F6F7F9; | ||
--c-header: #000; | ||
--c-text: #353841; | ||
--c-text: #1b1d21; | ||
--c-tip-bg: rgb(69, 212, 140, 0.4); | ||
--c-text-accent:#3D50F5; | ||
--border: #EAECEF; | ||
} | ||
|
||
|
||
html.dark { | ||
--c-brand: #B3C7FF; //changes accent color | ||
--c-brand: rgba(129, 129, 215, 0.765); //changes accent color | ||
--c-border: #25262c; //track color | ||
--c-brand-light: #778bc2; //get started button hover | ||
--c-tip: #30d56f; //tip bubble color | ||
--c-bg: #17181C;//dark mode background | ||
--c-nav:#23262F; | ||
--c-header: #fff; | ||
--c-text: #BCC0C8; | ||
--c-text-accent: #67D6ED; //accent in nav | ||
--c-text: #e2e2e2; //text for everything including nav | ||
--c-tip-bg: rgb(48, 213, 111, 0.1); | ||
--border: #25262C; | ||
} | ||
.sidebar::-webkit-scrollbar { | ||
width: 0%; | ||
height: 0%; | ||
|
||
::-webkit-scrollbar | ||
{ | ||
width: 0; | ||
height: 0; | ||
} | ||
.navbar{ | ||
background-color: var(--c-nav); | ||
border: none; | ||
|
||
.sidebar::-webkit-scrollbar | ||
{ | ||
background-color: red; | ||
} | ||
|
||
.sidebar{ | ||
background-color: var(--c-nav); | ||
font-size: 14px; | ||
border: none; | ||
margin-top: 1px; | ||
} | ||
|
||
.header-anchor{ | ||
color: var(--c-header); | ||
} | ||
|
||
.header-anchor p{ | ||
color: var(--c-text); | ||
} | ||
|
@@ -84,3 +87,12 @@ html.dark { | |
div.theme-default-content:not(.custom), footer.page-meta:not(.custom), nav.page-nav:not(.custom) { | ||
max-width: 1800px; | ||
} | ||
|
||
.deviceSearch | ||
{ | ||
all: unset; | ||
background-color: var(--c-bg); | ||
border-radius: 10px; | ||
border: var(--border) solid 1px; | ||
padding-left: 10px; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not sure it's selecting multiple lines here There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. looks like it did actually, nice that they fixed that |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does this change relate to "better" dark mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 90?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
formatting and i dont see an issue including that when modifying the file
below 90 relate to the search bar which you questioned already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, the block of code below that. GH doesn't allow you to select multiple lines to comment on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recently learned it does actually, try holding shift while clicking on any additional lines, that is, unless I misuse that feature