Better Looking Darkmode + Update Nav button text #180
Conversation
Why its only css |
|
SEO |
|
Search Engine Optimization? |
Are these "checks" related to the css that was actually changed, and/or related to the css already in the project? |
|
I want to verify that the changed css doesn't worsen lighthouse scores. Won't take long after im done with my day job |
| @@ -40,7 +40,7 @@ If you're on a smaller screen, scroll sideways to see whole table. | |||
| ::: | |||
|
|
|||
| <AddScript script-url="../../supported-devices.js"/> | |||
| <p>Search: <input type="text" class="deviceSearch"></p> | |||
| <p><input type="text" class="deviceSearch" placeholder="Enter Your Boardname"></p> | |||
There was a problem hiding this comment.
this change is unrelated to the PR
|
Again, what does "better" mean? it's meaningless word. Tell us exactly what you are changing and why |
| @@ -84,3 +87,12 @@ html.dark { | |||
| div.theme-default-content:not(.custom), footer.page-meta:not(.custom), nav.page-nav:not(.custom) { | |||
| max-width: 1800px; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
how does this change relate to "better" dark mode?
There was a problem hiding this comment.
formatting and i dont see an issue including that when modifying the file
below 90 relate to the search bar which you questioned already
There was a problem hiding this comment.
line 90?
no, the block of code below that. GH doesn't allow you to select multiple lines to comment on
There was a problem hiding this comment.
GH doesn't allow you to select multiple lines to comment on
I recently learned it does actually, try holding shift while clicking on any additional lines, that is, unless I misuse that feature
|
The markdown changes are still / again in this branch/PR |
… in `supported devices`
|
I will be redoing this, in a new branch closing |
| border-radius: 10px; | ||
| border: var(--border) solid 1px; | ||
| padding-left: 10px; | ||
| } |
There was a problem hiding this comment.
not sure it's selecting multiple lines here
There was a problem hiding this comment.
looks like it did actually, nice that they fixed that
No description provided.