Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test lsu_bus_buffer #289

Merged
merged 6 commits into from
Dec 17, 2024
Merged

test lsu_bus_buffer #289

merged 6 commits into from
Dec 17, 2024

Conversation

wsipak
Copy link
Collaborator

@wsipak wsipak commented Dec 11, 2024 •
edited
Loading

This modifies the testbench to test the part in lsu_bus_buffer which depends on lsu_bus_clk_en signal currently tied to 1.
Currently this state is never reached.
The testbench already has code to perform pre-operation resets and checks. Let's extend this part to let the core run with lsu_bus_clk_en being 10 times slower than core_clk, which makes the buffer reach the previously unreached state.

@wsipak wsipak force-pushed the wsip/lsu_bus_buffer branch 2 times, most recently from 4e63202 to ce5e10d Compare December 11, 2024 16:01
@github-actions GitHub Actions
Copy link

Links to coverage and verification reports for this PR (#289) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

1 similar comment
@github-actions GitHub Actions
Copy link

Links to coverage and verification reports for this PR (#289) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

@wsipak wsipak force-pushed the wsip/lsu_bus_buffer branch 2 times, most recently from 13ae875 to 8eda772 Compare December 12, 2024 11:59
@wsipak wsipak marked this pull request as ready for review December 12, 2024 12:32
@github-actions GitHub Actions
Copy link

Links to coverage and verification reports for this PR (#289) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

@wsipak wsipak marked this pull request as draft December 12, 2024 16:44
@wsipak wsipak force-pushed the wsip/lsu_bus_buffer branch from 8eda772 to c6087c0 Compare December 12, 2024 17:25
@github-actions GitHub Actions
Copy link

Links to coverage and verification reports for this PR (#289) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

1 similar comment
@github-actions GitHub Actions
Copy link

Links to coverage and verification reports for this PR (#289) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

@wsipak wsipak force-pushed the wsip/lsu_bus_buffer branch from 694bf82 to ca561c3 Compare December 16, 2024 14:43
@wsipak wsipak force-pushed the wsip/lsu_bus_buffer branch 4 times, most recently from 64a5864 to e7cd964 Compare December 16, 2024 15:19
@wsipak wsipak force-pushed the wsip/lsu_bus_buffer branch from e7cd964 to 2a0fd68 Compare December 16, 2024 15:28
@github-actions GitHub Actions
Copy link

Links to coverage and verification reports for this PR (#289) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

@wsipak wsipak marked this pull request as ready for review December 16, 2024 20:04
tmichalak
tmichalak approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@tmichalak tmichalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmichalak tmichalak merged commit e3b50f0 into main Dec 17, 2024
393 checks passed
@wsipak wsipak deleted the wsip/lsu_bus_buffer branch December 18, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmichalak tmichalak tmichalak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wsipak @tmichalak