Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move perr_dat_ff closer to ICACHE_ENABLE-gated logic #153

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

koluckirafal
Copy link
Contributor

@koluckirafal koluckirafal commented Dec 14, 2023

This PR moves perr_dat_ff latch and some associated signal definitions closer to ICACHE_ENABLE-gated logic.

Fixes #149.

design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
@koluckirafal koluckirafal changed the title Move perr_dat_ff closer to ICACHE_ENABLED-gated logic Move perr_dat_ff closer to ICACHE_ENABLE-gated logic Dec 14, 2023
design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
Copy link

Links to coverage and verification reports for this PR (#153) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

@calebofearth
Copy link
Contributor

Is this Pull Request stable/ready to complete?

design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
design/ifu/el2_ifu_mem_ctl.sv Outdated Show resolved Hide resolved
Internal-tag: [#52136]
Signed-off-by: Rafal Kolucki <[email protected]>
@koluckirafal
Copy link
Contributor Author

PR is ready, restarted the CI to make sure it's green and will merge once it is

@tmichalak tmichalak merged commit 02f044f into chipsalliance:main Mar 27, 2024
164 of 165 checks passed
@tmichalak tmichalak deleted the gh-149 branch October 22, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synthesis issue due to perr_dat_ff signal
3 participants