Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAP-1584 Fix alignment and positioning of error icon for complaint date to match other date filters #555

Merged
merged 2 commits into from
Oct 30, 2024
Merged

DATAP-1584 Fix alignment and positioning of error icon for complaint date to match other date filters #555

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b01775
Fix alignment and positioning of error icon for complaint date to mat…
Oct 30, 2024
c06d14b
moved key to wrapper div
Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/components/Filters/CompanyReceivedFilter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,12 +184,14 @@ export const CompanyReceivedFilter = () => {
{errors.length ? (
<div className="a-form-alert a-form-alert--error" role="alert">
{errors.map((message, key) => (
<div key={key}>
{message}
<>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think key should be moved to the wrapper container for this repeater so react doesn't throw a warning.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. This has been updated accordingly.

<span aria-hidden="true">
{getIcon('delete-round', 'cf-icon-delete-round')}
</span>
</div>
<div className="a-form-alert__text" key={key}>
{message}
</div>
</>
))}
</div>
) : null}
Expand Down