Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAP-1584 Fix alignment and positioning of error icon for complaint date to match other date filters #555

Merged

Conversation

cdmh219
Copy link
Collaborator

@cdmh219 cdmh219 commented Oct 30, 2024

Date received error icon displays incorrectly. Fix was made to change position and alignment of icon.

Additions

Removals

Changes

Testing

  • Go to "Date CFPB Received Complaint" filter
  • For the "From" date, enter "11/30/2024"
  • For the "Through" date, enter "10/30/2024"
  • Error message with icon "'From' date must be less than 'through' date" should display below "Date Range" pill filters. Icon display should match below screenshot.

Screenshots

Screenshot 2024-10-30 at 10 28 24 AM

Notes

Todos

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@cdmh219 cdmh219 requested a review from flacoman91 October 30, 2024 15:19
@@ -184,12 +184,14 @@ export const CompanyReceivedFilter = () => {
{errors.length ? (
<div className="a-form-alert a-form-alert--error" role="alert">
{errors.map((message, key) => (
<div key={key}>
{message}
<>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think key should be moved to the wrapper container for this repeater so react doesn't throw a warning.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. This has been updated accordingly.

@cdmh219 cdmh219 requested a review from flacoman91 October 30, 2024 17:46
Copy link
Contributor

@flacoman91 flacoman91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@flacoman91 flacoman91 added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 9bfbe7e Oct 30, 2024
2 checks passed
@flacoman91 flacoman91 deleted the DATAP-1584-Date-received-error-icon-displays-incorrectly branch October 30, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants