Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update website to reference GatewayAPI V1 #1372

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Update website to reference GatewayAPI V1 #1372

merged 1 commit into from
Dec 20, 2023

Conversation

ThatsMrTalbot
Copy link
Contributor

This was originally merged to the wrong branch #1368

This is the PR to the correct branch

@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 20, 2023
@ThatsMrTalbot
Copy link
Contributor Author

I think release-next needs rebasing from live, I did not change all those files

@netlify Netlify
Copy link

netlify bot commented Dec 20, 2023

✅ Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit c7b6181
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/6582c994ef12d00008f86520
😎 Deploy Preview https://deploy-preview-1372--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@inteon
Copy link
Member

inteon commented Dec 20, 2023

/check-dco

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Dec 20, 2023
inteon
inteon reviewed Dec 20, 2023
View reviewed changes
Copy link
Member

@inteon inteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thanks for the improvements.
/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2023
@jetstack-bot jetstack-bot merged commit f1141ee into cert-manager:release-next Dec 20, 2023
1 check passed
This was referenced Dec 20, 2023
Closed
Merged
@ThatsMrTalbot ThatsMrTalbot mentioned this pull request Jan 8, 2024
Merged
This was referenced Jan 8, 2024
Closed
Merged
@ThatsMrTalbot ThatsMrTalbot mentioned this pull request Jan 16, 2024
Closed
@jetstack-bot jetstack-bot mentioned this pull request Jan 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inteon inteon inteon left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThatsMrTalbot @inteon @jetstack-bot