Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CLI reference #1371

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Update CLI reference #1371

merged 1 commit into from
Jan 2, 2024

Conversation

inteon
Copy link
Member

@inteon inteon commented Dec 20, 2023

Adds newly added flags and removes hidden flags.

@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 20, 2023
@inteon inteon force-pushed the update_cli_reference branch from 5ccd2fa to b6e6a56 Compare December 20, 2023 09:40
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 20, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 20, 2023

✅ Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 5ccd2fa
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/6582b61d1ae884000874f03c
😎 Deploy Preview https://deploy-preview-1371--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 20, 2023 •
edited
Loading

✅ Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit bd2d97c
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/6593ff386c04aa00072578a6
😎 Deploy Preview https://deploy-preview-1371--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

SgtCoDFish
SgtCoDFish reviewed Jan 2, 2024
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was this generated? This doesn't match the changes from ./scripts/gendocs/generate-new-import-path-docs when run locally.

This is obviously an improvement, but my recollection was that this was done by a script!

@inteon inteon force-pushed the update_cli_reference branch from b6e6a56 to bf06e29 Compare January 2, 2024 12:15
@jetstack-bot jetstack-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 2, 2024
@inteon
Copy link
Member Author

inteon commented Jan 2, 2024

How was this generated? This doesn't match the changes from ./scripts/gendocs/generate-new-import-path-docs when run locally.

This is obviously an improvement, but my recollection was that this was done by a script!

Thanks for pointing me to that script, I did not realise it existed.
I updated some issues that caused the script to fail for me & pointed the script to master, so it is up-to-date for release-next.

@inteon inteon force-pushed the update_cli_reference branch from bf06e29 to bd2d97c Compare January 2, 2024 12:19
@inteon inteon requested a review from SgtCoDFish January 2, 2024 12:19
SgtCoDFish
SgtCoDFish approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Cheers!

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2024
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2024
@jetstack-bot jetstack-bot merged commit 5782b34 into cert-manager:release-next Jan 2, 2024
3 of 4 checks passed
This was referenced Jan 8, 2024
Closed
Merged
This was referenced Jan 19, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inteon @jetstack-bot @SgtCoDFish