Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cardano Tracer documentation: update & proofread #1386

Merged

Conversation

Icelandjack
Copy link
Contributor

Updating the documentation for Cardano Tracer.

@Icelandjack Icelandjack marked this pull request as draft January 29, 2025 09:04
@Icelandjack Icelandjack force-pushed the baldurb/update-docs branch 8 times, most recently from 68043dd to c256845 Compare February 3, 2025 14:53
@mgmeier mgmeier force-pushed the baldurb/update-docs branch from c256845 to 93d6e17 Compare February 5, 2025 12:06
@rphair rphair changed the title Updated the Cardano Tracer documentation. Cardano Tracer documentation: update & proofread Feb 5, 2025
@rphair
Copy link
Collaborator

rphair commented Feb 5, 2025

@Icelandjack this was submitted in Draft review status: are you still working on it, or will others? If not, I think it's a valid submission and should be marked Ready for Review. Please confirm which you think it should be.

I can see this is a welcome addition to #1383 which, in hindsight, seems only to have updated the "Quick Start" document.

@rphair rphair added the documentation Improvements or additions to documentation label Feb 5, 2025
@Icelandjack Icelandjack marked this pull request as ready for review February 6, 2025 08:59
@mgmeier
Copy link
Contributor

mgmeier commented Feb 6, 2025

@rphair It's ready for review now :)

Copy link
Collaborator

@CarlosLopezDeLara CarlosLopezDeLara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve, but please take a look at the suggestions I made.

@CarlosLopezDeLara CarlosLopezDeLara merged commit d521c4f into cardano-foundation:staging Feb 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants