-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record scrollbar movement in dialogs #662
Record scrollbar movement in dialogs #662
Conversation
I have two general comments on this.
|
I think the ui's randomized ids are deterministic through a ui_rand object. I added the id to this one because I had already recorded a replay where the id wasn't recorded, so I wanted to be able to edit the replay xml to retroactively set the name to something I knew it would be. |
c02dd40
to
fe8841e
Compare
@CelticMinstrel I removed the unnecessary 'name' attribute from about-boe and confirmed that a scrollpane without a name will record and replay correctly. |
fe8841e
to
dbdde01
Compare
@CelticMinstrel as you pointed out, controls in containers weren't getting their name fields set. In order to do that while avoiding future merge conflicts, I cherry-picked my commit which makes containers resolve relative positioning in their elements. |
I forgot to stage one more replay system fix. This enables recording and replaying scrollbars in dialogxml scrollpanes.