Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay fixes #657

Merged
merged 9 commits into from
Feb 24, 2025
Merged

Replay fixes #657

merged 9 commits into from
Feb 24, 2025

Conversation

NQNStudios
Copy link
Collaborator

@NQNStudios NQNStudios commented Feb 23, 2025

A round of replay system fixes and improvements.

  • replaying the debug help window was broken in 2 ways which I fixed
  • Fix Record replays in memory #559 -- When we observe bugs in random sessions, we no longer have to regret that we didn't pass --record at the command line. The replay data is kept in memory and writing it out can be enabled with debug action Z.
  • Recording replays into the working directory by default is pretty wonky, because the working directory is usually a build output folder that might be clobbered by a scons -c, wiping out important replays. Also, if the working directory is the Visual Studio project folder, you end up adding untracked files to your repo folder which can get annoying. So - I've made the default replay directory a folder alongside the tempDir that already exists. On Windows, this is in AppData, on Mac it's in Application Support, etc. But if you pass an explicitly relative or absolute path, it is resolved as expected.
  • I made a mistake a while ago that made the Debug action N (end scenario) not get recorded. Fixed!

@NQNStudios NQNStudios added bug enhancement replay Affects the replay system labels Feb 23, 2025
@NQNStudios
Copy link
Collaborator Author

I'm rounding up a bunch of these fixes as I've finally made a replay that contains (almost) all of the debug actions. More to come.

@NQNStudios
Copy link
Collaborator Author

With those last two, the whole replay runs correctly.

@CelticMinstrel CelticMinstrel merged commit 11f5ab1 into calref:master Feb 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement replay Affects the replay system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Record replays in memory
2 participants