Fix text appearing out of alignment with adjusted booms #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/game/boe.combat.cpp
Outdated
| void damage_target(short target,short dam,eDamageType type,short sound_type) { | ||
| if(target == 6) return; | ||
| short damage_target(short target,short dam,eDamageType type,short sound_type, bool do_print, short who_hit, eRace race) { | ||
| if(target == 6) return 0; |
There was a problem hiding this comment.
Come to think of it, I guess this should exclude everything from 6 up to (but not including) 100…
Maybe also numbers >= univ.town.monst.size() + 100.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the rendering of melee damage booms on enemies larger than 1x1. It also doesn't break spell booms (which already worked).
I saw a place to do a refactor which I thought would make it easier to debug this. The fix (in the second commit) could be cherry-picked without the refactor if it looks like I got that wrong.
Fix #127