Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix another crash on page 2 of spell picker #634

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

NQNStudios
Copy link
Collaborator

@NQNStudios NQNStudios commented Feb 18, 2025

Page 2 of the spell picker has always been touch-and-go... I found a new crash today because of trying to assign an LED status to a button which would be hidden on page 2. We simply can say that a PC cannot cast the None spell, to fix this.

@NQNStudios NQNStudios added the bug label Feb 18, 2025
@CelticMinstrel
Copy link
Member

I think the NONE spell is actually used somewhere – probably the "Start Targeting" special node? We should make sure that this change doesn't break special targeting. (It might be fine if the "can cast" check isn't made in that context.)

@NQNStudios
Copy link
Collaborator Author

NQNStudios commented Feb 20, 2025

I don't see the can_cast() check being called for special node targeting.

But also, I found that special node targeting isn't working even without this change (#636)

The behavior of the Start Targeting node, with or without this change, is that you can pick a space, but nothing will happen.

@CelticMinstrel CelticMinstrel merged commit 907c459 into calref:master Feb 21, 2025
6 checks passed
@NQNStudios NQNStudios deleted the fix-spell-crash branch February 21, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants