Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when dumpfound/sleep status is 0 bound low to 0. Fix #138 #633

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

NQNStudios
Copy link
Collaborator

There already was a check to prevent this bug. I don't fully understand it.
Changing > to >= fixes the problem. But does it break these statuses in other contexts?

Fix #138

@NQNStudios NQNStudios changed the title when status is 0 bound low to 0. Fix #138 when dumpfound/sleep status is 0 bound low to 0. Fix #138 Feb 18, 2025
@NQNStudios NQNStudios added the bug label Feb 18, 2025
@CelticMinstrel
Copy link
Member

But does it break these statuses in other contexts?

Probably test the Hyperactivity spell? That's the only thing that adds negative sleep as far as I'm aware.

For negative dumbfounding, there's a new item spell.

I don't think items are capable of inflicting hyperactivity or enlightenment to begin with, actually. That might be a flaw in the "Affect status effect" ability… but I suppose you could try creating such an item as a test.

My suspicion is that this could indeed break things like Hyperactivity.

@NQNStudios
Copy link
Collaborator Author

NQNStudios commented Feb 19, 2025 via email

@CelticMinstrel CelticMinstrel merged commit 85096de into calref:master Feb 21, 2025
6 checks passed
@NQNStudios NQNStudios deleted the fix-dumbfound branch February 21, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There's a potential issue with items that cure sleep or dumbfounding
2 participants