Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 test(coinbase): Add wait loop for order status to ensure it is open #1915

Merged
merged 1 commit into from
Feb 26, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pkg/exchange/coinbase/exchange_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,17 @@ func Test_OrdersAPI(t *testing.T) {
order, err = ex.QueryOrder(ctx, types.OrderQuery{Symbol: "ETHUSD", OrderID: order.UUID, ClientOrderID: order.UUID})
assert.NoError(t, err)

// the status might be pending at the beginning. Wait until it is open
// only retry 5 times
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

for i := 0; i < 5; i++ {
if order.OriginalStatus == "open" {
break
}
time.Sleep(time.Millisecond * 500)
order, err = ex.QueryOrder(ctx, types.OrderQuery{Symbol: "ETHUSD", OrderID: order.UUID, ClientOrderID: order.UUID})
assert.NoError(t, err)
}

orders, err := ex.QueryOpenOrders(ctx, "ETHUSD")
assert.NoError(t, err)
found := false
Expand Down
Loading