🔧 test(coinbase): Add wait loop for order status to ensure it is open #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dboyliao
force-pushed
the
dboy/coinbase-test-fix
branch
from
d0a7249 to
a0cc16c
Compare
kbearXD
approved these changes
Feb 26, 2025
narumiruna
approved these changes
Feb 26, 2025
dboyliao
force-pushed
the
dboy/coinbase-test-fix
branch
from
a0cc16c to
dbf5b80
Compare
narumiruna
reviewed
Feb 26, 2025
| @@ -71,6 +71,17 @@ func Test_OrdersAPI(t *testing.T) { | |||
| order, err = ex.QueryOrder(ctx, types.OrderQuery{Symbol: "ETHUSD", OrderID: order.UUID, ClientOrderID: order.UUID}) | |||
| assert.NoError(t, err) | |||
|
|
|||
| // the status might be pending at the beginning. Wait until it is open | |||
| // only retry 5 times | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.