Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: [max] fix GetDepositHistoryRequest #1695

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

c9s
Copy link
Owner

@c9s c9s commented Aug 16, 2024

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 219 BBG.

@c9s c9s enabled auto-merge August 16, 2024 05:49
@c9s c9s merged commit 098de22 into main Aug 16, 2024
3 checks passed
@c9s c9s deleted the c9s/max/fix-deposit-history-query-api branch August 16, 2024 05:53
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 224 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xd4f970f8c9e6a2ea1cb3ce779f8cd4e25d903abe16030a7535346909b4903208

Thank you for your contribution!

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 22.91%. Comparing base (7488a10) to head (b88aff6).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/exchange/max/exchange.go 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1695      +/-   ##
==========================================
- Coverage   22.91%   22.91%   -0.01%     
==========================================
  Files         606      606              
  Lines       45002    45003       +1     
==========================================
  Hits        10311    10311              
- Misses      33939    33940       +1     
  Partials      752      752              
Files Coverage Δ
pkg/exchange/max/maxapi/account.go 0.00% <ø> (ø)
pkg/exchange/max/exchange.go 0.34% <0.00%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7488a10...b88aff6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants