Merge pull request #1695 from c9s/c9s/max/fix-deposit-history-query-api

FIX: [max] fix GetDepositHistoryRequest
c9s · Aug 16, 2024 · 098de22 · 098de22
2 parents 7488a10 + b88aff6
commit 098de22
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 31 deletions.
diff --git a/pkg/exchange/max/exchange.go b/pkg/exchange/max/exchange.go
@@ -846,6 +846,7 @@ func (e *Exchange) QueryWithdrawHistory(
 
 		withdraws, err := req.
 			Timestamp(startTime).
+			Order("asc").
 			Limit(limit).
 			Do(ctx)
 
@@ -927,8 +928,8 @@ func (e *Exchange) QueryDepositHistory(
 		}
 
 		deposits, err := req.
-			From(startTime).
-			To(endTime).
+			Timestamp(startTime).
+			Order("asc").
 			Limit(limit).
 			Do(ctx)
 

diff --git a/pkg/exchange/max/maxapi/account.go b/pkg/exchange/max/maxapi/account.go
@@ -133,15 +133,17 @@ type Deposit struct {
 	UpdatedAt       types.MillisecondTimestamp `json:"updated_at"`
 }
 
-//go:generate GetRequest -url "v2/deposits" -type GetDepositHistoryRequest -responseType []Deposit
+//go:generate GetRequest -url "v3/deposits" -type GetDepositHistoryRequest -responseType []Deposit
 type GetDepositHistoryRequest struct {
 	client requestgen.AuthenticatedAPIClient
 
-	currency *string    `param:"currency"`
-	from     *time.Time `param:"from,seconds"` // seconds
-	to       *time.Time `param:"to,seconds"`   // seconds
-	state    *string    `param:"state"`        // submitting, submitted, rejected, accepted, checking, refunded, canceled, suspect
-	limit    *int       `param:"limit"`
+	currency  *string    `param:"currency"`
+	timestamp *time.Time `param:"timestamp,milliseconds"` // seconds
+	state     *string    `param:"state"`                  // submitting, submitted, rejected, accepted, checking, refunded, canceled, suspect
+
+	order *string `param:"order"`
+
+	limit *int `param:"limit"`
 }
 
 func (c *RestClient) NewGetDepositHistoryRequest() *GetDepositHistoryRequest {

diff --git a/pkg/exchange/max/maxapi/get_deposit_history_request_requestgen.go b/pkg/exchange/max/maxapi/get_deposit_history_request_requestgen.go