Merge pull request #1694 from c9s/c9s/max/fix-withdrawal-query-api

FIX: [max] fix max withdrawal api parameters
c9s · Aug 16, 2024 · 7488a10 · 7488a10
2 parents a916859 + 4154cc9
commit 7488a10
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 23 deletions.
diff --git a/pkg/exchange/max/exchange.go b/pkg/exchange/max/exchange.go
@@ -845,8 +845,7 @@ func (e *Exchange) QueryWithdrawHistory(
 		}
 
 		withdraws, err := req.
-			From(startTime).
-			To(endTime).
+			Timestamp(startTime).
 			Limit(limit).
 			Do(ctx)
 

diff --git a/pkg/exchange/max/maxapi/account.go b/pkg/exchange/max/maxapi/account.go
@@ -205,11 +205,15 @@ type Withdraw struct {
 type GetWithdrawHistoryRequest struct {
 	client requestgen.AuthenticatedAPIClient
 
-	currency *string    `param:"currency"`
-	state    *string    `param:"state"`        // submitting, submitted, rejected, accepted, checking, refunded, canceled, suspect
-	from     *time.Time `param:"from,seconds"` // seconds
-	to       *time.Time `param:"to,seconds"`   // seconds
-	limit    *int       `param:"limit"`
+	currency  *string    `param:"currency"`
+	state     *string    `param:"state"`                  // submitting, submitted, rejected, accepted, checking, refunded, canceled, suspect
+	timestamp *time.Time `param:"timestamp,milliseconds"` // milli-seconds
+
+	// order could be desc or asc
+	order *string `param:"order"`
+
+	// limit's default = 50
+	limit *int `param:"limit"`
 }
 
 func (c *RestClient) NewGetWithdrawalHistoryRequest() *GetWithdrawHistoryRequest {

diff --git a/pkg/exchange/max/maxapi/get_withdraw_history_request_requestgen.go b/pkg/exchange/max/maxapi/get_withdraw_history_request_requestgen.go