chore: fix build on gcc 10 #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsl
commented
Jun 30, 2020
Comment on lines
+13
to
+26
| build: [ | ||
| ["dune" "subst"] {pinned} | ||
| [ | ||
| "dune" | ||
| "build" | ||
| "-p" | ||
| name | ||
| "-j" | ||
| jobs | ||
| "@install" | ||
| "@runtest" {with-test} | ||
| "@doc" {with-doc} | ||
| ] | ||
| ] |
There was a problem hiding this comment.
Not sure what this is about. All I've done is tweak the dependencies, the dune-project lang, and run esy.
|
/azp run |
|
There was an error handling pipeline event 00022995-427b-4870-bd9d-212194b0b976. The command could not be run. |
|
:( caching on the windows CI box might be broken |
This was referenced Jun 30, 2020
wokalski
approved these changes
Jul 11, 2020
Comment on lines
+13
to
+26
| build: [ | ||
| ["dune" "subst"] {pinned} | ||
| [ | ||
| "dune" | ||
| "build" | ||
| "-p" | ||
| name | ||
| "-j" | ||
| jobs | ||
| "@install" | ||
| "@runtest" {with-test} | ||
| "@doc" {with-doc} | ||
| ] | ||
| ] |
|
I think we can erase this devDeps on dune2.5.0 because [email protected] has received the proper gcc with upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCaml 4.8 doesn't build with gcc 10, so this bumps it to 4.10 in dev, and pins opam to 2.5.0 to get rid of the secondary compiler, which is also 4.8.