fix(ppx): allow locally abstract types #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you bump dune version to >=1.11 in package.json |
|
What would that do? And ought it not be done in #79 instead, or is there something specific to this? |
|
Yep your right. |
wokalski
reviewed
Jul 11, 2020
glennsl
force-pushed
the
fix/ppx/allow-locally-abstract-type
branch
from
2998357 to
d57fd63
Compare
|
I think I've addressed all your concerns now @wokalski, but let me know if there's anything else! |
wokalski
approved these changes
Jul 12, 2020
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #79 to remove the noise