Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Validate PR with GitHub Actions. #69

Closed
wants to merge 90 commits into from

Conversation

Et7f3
Copy link
Contributor

@Et7f3 Et7f3 commented Nov 30, 2019

This PR re-open #52 (because it started with a fork of @ulrikstrid branch)

Most notably Github Actions' cache is too limited. 500 megabytes is not enough for esy!

Originally posted by @wokalski in #52 (comment)

With #59 the cache tarball go from 420 Mo to 360Mo and can be cached. (see my actions run it run in 2 minutes after downloading esy)

d185e75 fix #58

What should be done

@Et7f3
Copy link
Contributor Author

Et7f3 commented Dec 5, 2019

In last I use the advanced template so feature, enhancement, fix, bugfix, bug, chore label can be added.

@Et7f3
Copy link
Contributor Author

Et7f3 commented Dec 5, 2019

Ok I get 403 because it is not merged but it work fine in my fork Et7f3#2 (comment)

@Et7f3
Copy link
Contributor Author

Et7f3 commented Dec 5, 2019

Regarding formatting, I think it's a good idea to add auto format. Pushing commits from CI is sort of controversial but overall it'll be a quality of life improvement +1.

Can we add a message from a bot like:

I've updated your test lock files and formatted the code. Please pull the last commit before pushing any more changes.

Done :)

@Et7f3
Copy link
Contributor Author

Et7f3 commented Dec 5, 2019

You can customize message if you want :)
image

@wokalski
Copy link
Member

wokalski commented Dec 6, 2019

That's extremely good. One thing, could you please organise the commits a bit more? Or should I just squash it all? There are quite a few changes. I suppose most of them are lock file related but nevertheless 🙂.

@Et7f3
Copy link
Contributor Author

Et7f3 commented Dec 6, 2019

Lot of commits come from merge I will try rebasing so this noise disapear.

@Et7f3 Et7f3 closed this Dec 15, 2019
@Et7f3 Et7f3 deleted the ulrikstrid/validate-pr-gh-actions branch December 15, 2019 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn on CI if esy.lock is not up to date
3 participants