-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Et7f3/GitHub actions workflows #70
Et7f3/GitHub actions workflows #70
Conversation
😃 All target have |
I don’t think we need stale. I understand the benefits of releases on separate branches but I’d rather stick to the simple setup where merging a change with a different version number on master causes npm release. |
Ok so it is ready to merge :). Npm release can also be run on tag creation. |
Ok, I think it aged enough to be merged. Just kidding. I'm a bad maintainer but thankfully there are no angry people in this community. Does this remove all things azure, too? I don't think we need it anymore. Great job @Et7f3. You're doing great job. |
.azure-pipelines are still in place. Feel free to get rid of them, too! |
On second thought, making suggestions to a contributor after months of silence doesn't seem like the best idea, lol. If you don't have time/don't want to now, just let me know and I'll merge as is. |
For code archeologists: The reason why I was sceptical initially is that it just worked on azure, azure is (was?) much more generous on the free/OSS plan, and azure is (arguably) more robust. There has been only one technical change (big cache on GA) and multiple UX ones that caused me to reconsider. Azure UI/UX often doesn't work, is slightly confusing and GA are simply a much better fit for an open source project from my experience. |
No because you asked 8c7c51a
Not implemented 🙂.
At the moment the cache limit is 2 GB per repository. It is enough if we just try to compile and run the test on latest ocaml we support (we can even have 4.04 support). If we want to cache and test all version of OCaml/OS the matrix is prettry large and we exceed the cache limit (3 versions x 400 Mo for windows+2 OS x 3 versions x 200Mo for mac/linux). I don't know why windows is heavier but it is too much to drop all azure ci. |
Thank you for the PR @Et7f3. I'm looking forward to seeing release drafter in action 😄. |
Oups I wanted to rename my branch but I have deleted the old one (and github close the PR #69)
@wokalski Do you want https://github.com/actions/stale ?
Do you want release on new branch is created like on branch name match
*.*.*
launch npm release script ? With a branch per version you can backport easily + it is like dune/ocaml/esy do.This PR close #58