Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package to dune-project and generate opam file #66

Merged
merged 1 commit into from
Dec 2, 2019
Merged

Add package to dune-project and generate opam file #66

merged 1 commit into from
Dec 2, 2019

Conversation

ulrikstrid
Copy link
Collaborator

No description provided.

@wokalski
Copy link
Member

Can we get some verification that it's up to date on CI?

@ulrikstrid
Copy link
Collaborator Author

I think we could add a opam.json that depends in the opam file and see if it builds. Would that be good enough?

@wokalski
Copy link
Member

I guess it could be part of the lint stage together with esy fmt. Essentially it's as simple as git st after running the build, isn't it?

@wokalski wokalski merged commit 7ca068e into master Dec 2, 2019
@wokalski wokalski deleted the add-opam-file branch December 2, 2019 08:14
@wokalski wokalski mentioned this pull request Dec 2, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ulrikstrid @wokalski