Move all tests over to Rely #59
Conversation
ulrikstrid
changed the title
| # windows_408: { OCAML_VERSION: "4.08", platform: Windows, vmImage: windows-latest, CACHE_FOLDER: $(Pipeline.Workspace)\cache }, | ||
| windows_406: { OCAML_VERSION: "4.06", platform: Windows, vmImage: windows-latest, CACHE_FOLDER: $(Pipeline.Workspace)\cache }, | ||
| windows_407: { OCAML_VERSION: "4.07", platform: Windows, vmImage: windows-latest, CACHE_FOLDER: $(Pipeline.Workspace)\cache }, | ||
| windows_408: { OCAML_VERSION: "4.08", platform: Windows, vmImage: windows-latest, CACHE_FOLDER: $(Pipeline.Workspace)\cache }, |
| "@esy-ocaml/[email protected]@d41d8cd9" | ||
| ], | ||
| "devDependencies": [ "[email protected]@d41d8cd9" ] | ||
| }, |
There was a problem hiding this comment.
So much deps removed maybe we can go below < 400 MO of cache now.
|
|
||
| Alcotest.run(~argv=[|"--verbose --color"|], "Brisk", [("Core", core)]); |
There was a problem hiding this comment.
It is conserved ? "Brisk", [("Core", core)]
There was a problem hiding this comment.
I could nest the describe some more, do you want this @wokalski ?
There was a problem hiding this comment.
Not relevant anymore. It's a relict of the distant past.
| expectInt( | ||
| ~label="The dispose should not have been run yet", | ||
| 0, | ||
| effectDisposeCallCount^, |
There was a problem hiding this comment.
I think it's on line 953, the diff is a bit hard to read here.
| @@ -221,7 +222,8 @@ module EmptyComponentWithAlwaysEffect = { | |||
| }; | |||
|
|
|||
| module EmptyComponentWithOnMountEffect = { | |||
| let%component make = (~onEffect, ~onEffectDispose, ()) => { | |||
| let%component make = | |||
| (~onEffect: unit => unit, ~onEffectDispose: unit => unit, ()) => { | |||
There was a problem hiding this comment.
Why are this type annotation needed ?
There was a problem hiding this comment.
It complained about not being able to generalize a type, but this is only used in tests so it doesn't bleed anywhere.
| # windows_408: { OCAML_VERSION: "4.08", platform: Windows, vmImage: windows-latest, CACHE_FOLDER: $(Pipeline.Workspace)\cache }, | ||
| windows_406: { OCAML_VERSION: "4.06", platform: Windows, vmImage: windows-latest, CACHE_FOLDER: $(Pipeline.Workspace)\cache }, | ||
| windows_407: { OCAML_VERSION: "4.07", platform: Windows, vmImage: windows-latest, CACHE_FOLDER: $(Pipeline.Workspace)\cache }, | ||
| windows_408: { OCAML_VERSION: "4.08", platform: Windows, vmImage: windows-latest, CACHE_FOLDER: $(Pipeline.Workspace)\cache }, |
| * outputs junit xml to the provided filepath, most CI solutions have | ||
| * integration with the junit xml format */ | ||
| Default, | ||
| JUnit("./junit.xml"), |
| type mount = list(testMountEntry); | ||
|
|
||
| type testHostItem('a) = | ||
| | MountElement(mountElement): testHostItem(mount); |
There was a problem hiding this comment.
I think this wrapper is redundant?
There was a problem hiding this comment.
This is not new, TestHelpers.re is the old Assert.re but I removed some stuff at the end and added a new function.
| type testHostItem('a) = | ||
| | MountElement(mountElement): testHostItem(mount); | ||
|
|
||
| type testState = { |
There was a problem hiding this comment.
It'd be great to move mountLog to testState. During insertNode child nodes should get a ref of mountLog to add updates to later. It'll make the tests less error prone. It's not a change for now though.
| MountChild(root, div, 0), | ||
| ]); | ||
| }) | ||
| }); |
| test("The effect should've been run", ({expect}) => { | ||
| state := state^ |> executeSideEffects; | ||
|
|
||
| expect.int(effectCallCount^).toBe(1); |
| ({expect}) => { | ||
| expect.int(effectDisposeCallCount^).toBe(1) | ||
| }); | ||
| }); |
| ({expect}) => { | ||
| expect.int(effectDisposeCallCount^).toBe(1) | ||
| }); | ||
| }); |
| 0, | ||
| effectDisposeCallCount^, | ||
| ); | ||
| expect.int(effectCallCount^).toBe(1); |
| MountChild(div, box("ImABox1"), 1), | ||
| ]); | ||
| }); | ||
| }); |
This allows us to test on Windows and we also get nice jUnit reporting