Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate PRs in Github Actions #52

Closed
wants to merge 1 commit into from

Conversation

ulrikstrid
Copy link
Collaborator

No description provided.

@ulrikstrid ulrikstrid force-pushed the ulrikstrid/validate-pr-gh-actions branch from e2af206 to 7d1b855 Compare November 10, 2019 09:53
@wokalski
Copy link
Member

@ulrikstrid IIRC the azure scripts have special handling for 4.04 too. I don't remember why 🤦‍♂

@ulrikstrid
Copy link
Collaborator Author

It skips 4.04 on Windows, do we need to run it on 4.04 since it's pretty old? Maybe bucklescript's version could be the lower bound?

@wokalski
Copy link
Member

I think lower bound should be min of whatever revery uses or bucklescript

@wokalski
Copy link
Member

As appealing as github actions are, azure-pipelines (#55) proved to be just too good.

@wokalski wokalski closed this Nov 17, 2019
@wokalski
Copy link
Member

Most notably Github Actions' cache is too limited. 500 megabytes is not enough for esy!

@wokalski wokalski deleted the ulrikstrid/validate-pr-gh-actions branch November 17, 2019 21:16
@Et7f3 Et7f3 mentioned this pull request Nov 30, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants