Add screenshot tests #351
Merged
Add screenshot tests #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
==========================================
- Coverage 86.96% 86.31% -0.66%
==========================================
Files 27 27
Lines 1220 1220
==========================================
- Hits 1061 1053 -8
- Misses 159 167 +8 ☔ View full report in Codecov by Sentry. |
adamltyson
force-pushed
the
screenshot
branch
3 times, most recently
from
bba32e4 to
1a2c76a
Compare
|
I've had to limit one of the tests due to #357. I can't work out the problem, so I'm leaving this PR as it is for now. I still think it's worth merging as it improves the screenshot tests slightly. |
|
tests are failing because neuromorpho is down again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've raised this PR to investigate #338. The test suggest that there is a problem specifically with Linux. Images are generated, but it's not what it's meant to be.