Rework New Bottle dialog #3653
Merged
Rework New Bottle dialog #3653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheEvilSkeleton
force-pushed
the
rework-new-dialog
branch
3 times, most recently
from
0523bbe to
90abebb
Compare
TheEvilSkeleton
force-pushed
the
rework-new-dialog
branch
4 times, most recently
from
a050b38 to
d56ddc5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
TheEvilSkeleton
force-pushed
the
rework-new-dialog
branch
2 times, most recently
from
7e20bb0 to
dc16aa4
Compare
A considerable chunk of the NewView widget needs to be reworked, starting with changing the name of the widget to BottlesNewBottleDialog.
We can simply use `GtkUtils.get_parent_window()`.
The dialog is split into 3 pages as opposed to 2. This makes transitioning between pages smoother, as it switches pages with a crossfade transition as opposed to replacing widgets and labels. The scrolled window displaying the output is moved to the completed page if there is an error, to keep the same functionality as the previous implementation. The second and last pages can also be dragged from anywhere, except the scrolled output.
This comes at the benefit of having access to the `::row-activated` signal, allowing us to select the desired row without going through if-else statements. This creates the `selected-environment` GObject property for the BottlesCheckRow widget that stores the selected environment.
This is mainly going to be useful for implementing an activated action to activate the create button.
This makes the dialog a bit narrower and increases the content height. The creating page has gotten a small rework to accommodate the height. The output label is bigger and fits better with different screen sizes. The status page was replaced with a GtkScrolledWindow, as implementing it ourselves gave us the control desired to better control the height of the output label without hardcoding a value.
`GtkWidget.get_style_context()` is deprecated.
The headings were removed, as there is no reason to keep cluttering the UI with unnecessary text. The Runner and bottle directory options are now available in every environment. Closes bottlesdevs#3036
This simplifies the labels by using less technical jargon. It also updates quotes.
TheEvilSkeleton
force-pushed
the
rework-new-dialog
branch
from
dc16aa4 to
c9ab9a9
Compare
The filters are re-implemented from the `filters` module. This is to avoid breaking compatibility with other users of the corresponding functions. However, eventually, we should adapt the module to only handle GtkFileDialog.
TheEvilSkeleton
force-pushed
the
rework-new-dialog
branch
from
0cbc8a6 to
2606b60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3036