-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up basic diplomat workflow #163
Conversation
I added a bunch of bindings! No tests yet, and I don't yet check in any bindings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I've ran cargo run -p diplomat-gen
and seen the header files it generates. Looks like a good start. Ideally we may want a contributing guide to make sure the wrapper lib is updated alongside the underlying temporal_rs code but it sounds like some CI can be added for that. I also don't think that's a blocker for this.
@jasonwilliams yep, as I mention in the issue, my plan is to do that in future PRs. My goal is to get this in a place where collaboration can happen, we can add CI and proper tests later. |
This is looking great! Thanks for looking into this and helping out! Out of curiosity, have you been able to take a look at #169? If I'm understanding diplomat correctly, I don't think that it will affect any subsequent work related to diplomat, but I wanted to confirm first. |
@nekevss it shouldn't matter, exposing it over FFI will be additional work but that's about it. One thing that could be tricky is if you ever decided to expose data sources for calendars: currently we're able to cheaply clone |
@Manishearth How does ICU4X expose provider APIs? Because I was thinking we could change |
We have |
FWIW my preference is for this to be merged, I could push more APIs, and might do that on my flight tomorrow, but it will be nice to have something in. |
This looks good to me! 😄 Just needs a rebase / merge with main |
Oh, I didn't realize those were mandatory. Done! |
Progress on #104
This adds a simple diplomat integration, but does not use it yet. When we start using it we should add CI that runs
cargo run -p diplomat-gen
and ensures there is no diff.