Remove test account type #1224
Merged
Remove test account type #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfc2822
force-pushed
the
remove-test-account-type
branch
from
68d8091 to
d16bfd3
Compare
rfc2822
force-pushed
the
remove-test-account-type
branch
from
d16bfd3 to
be03406
Compare
sunkup
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can get rid of the "test" account type in order to simplify the tests.
Originally, the "test" account type was introduced because when a normal account was created during the tests, it sometimes automatically started a sync adapter. It seems that this is currently not the case. We could also explicitly set it to
truenow if this would make it better for the tests, because for real users theSyncFrameworkIntegrationwill now take care of always settingisSyncablecorrectly.Reason to do this now is that I wanted to know whether I also have to create a "type" field for the accounts table in #1205. Without a separate test account type, there's no need for that.