Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Previously, only system accounts (of type DAVx5 account) were used for everything account-related. However we had services in the database, which referenced to system accounts.
This PR adds accounts to the database to advance into a direction that allows us to have a reliable SSOT for accounts that is under our control (system accounts aren't).
In the scope of phase 1 (this PR), accounts will additionally be mirrored in the database, but system accounts remain the actual data source. In a future PR, this will be reversed: the database then becomes the actual data source and system accounts can be managed as required.
Short description
AccountRepository
the true SSOT for accounts (includes gettingAccount
s always overfromAccount(name)
).TODO:
account_type_test
is still neccesary → see https://github.com/bitfireAT/davx5-ose/tree/test-account-typeaccountRepository.fromName(service.accountName)
not necessary whenaccountName
is a foreign keyDepends on #1224
Checklist