Sync workers: use data type enum instead of specific authority #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on missing tasks app permission during sync
rfc2822
force-pushed
the
sync-domains-2
branch
from
5ea1b0b to
2729055
Compare
rfc2822
force-pushed
the
sync-domains-2
branch
from
147f830 to
802a587
Compare
… handle manual sync interval
rfc2822
force-pushed
the
sync-domains-2
branch
from
df48775 to
3a44c0a
Compare
rfc2822
force-pushed
the
sync-domains-2
branch
from
77093e1 to
dc50917
Compare
…ate automatic syncs
rfc2822
force-pushed
the
sync-domains-2
branch
from
e0a0894 to
78c6194
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using sync authorities to control the sync (sync intervals, workers, etc.), we now use the
SyncDataType.This decouples sync authorities (actual content providers) and the type of sync.So we also don't need to look up the tasks provider when we shouldn't have to.
Automatic sync is now controlled by the
AutomaticSyncManager. Other code locations don't have to (and shouldn't) update the sync runners.