Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accounts to DB #1205

Draft
wants to merge 6 commits into
base: main-ose
Choose a base branch
from
Draft

Add accounts to DB #1205

wants to merge 6 commits into from

Conversation

rfc2822
Copy link
Member

@rfc2822 rfc2822 commented Dec 30, 2024

Purpose

Previously, only system accounts (of type DAVx5 account) were used for everything account-related. However we had services in the database, which referenced to system accounts.

This PR adds accounts to the database to advance into a direction that allows us to have a reliable SSOT for accounts that is under our control (system accounts aren't).

In the scope of phase 1 (this PR), accounts will additionally be mirrored in the database, but system accounts remain the actual data source. In a future PR, this will be reversed: the database then becomes the actual data source and system accounts can be managed as required.

Short description

  • Make AccountRepository the true SSOT for accounts (includes getting Accounts always over fromAccount(name)).
  • Create/update/delete accounts in the database when they're modified.

TODO:

Depends on #1224

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@rfc2822 rfc2822 linked an issue Dec 30, 2024 that may be closed by this pull request
6 tasks
@rfc2822 rfc2822 self-assigned this Dec 30, 2024
@rfc2822 rfc2822 force-pushed the 934-create-accounts-table-in-db branch from a43d493 to 01a9013 Compare December 30, 2024 17:03
@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Jan 1, 2025
Copy link

github-actions bot commented Jan 8, 2025

This PR/issue depends on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal improvement of existing functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Accounts table in DB
1 participant