Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump fedimint-tonic-lnd version #151

Merged
merged 2 commits into from
Oct 25, 2023
Merged

chore: bump fedimint-tonic-lnd version #151

merged 2 commits into from
Oct 25, 2023

Conversation

okjodom
Copy link
Collaborator

@okjodom okjodom commented Oct 24, 2023

  • The new version of fedimint-tonic-lnd supports connecting to LND nodes using IP addresses

@okjodom okjodom requested a review from sr-gi October 24, 2023 16:53
@okjodom okjodom mentioned this pull request Oct 24, 2023
Closed
sr-gi
sr-gi reviewed Oct 24, 2023
View reviewed changes
sim-lib/src/lnd.rs Outdated Show resolved Hide resolved
@okjodom okjodom force-pushed the tonic-bump branch 2 times, most recently from 29c7430 to 89e3567 Compare October 24, 2023 20:39
@okjodom
Copy link
Collaborator Author

okjodom commented Oct 24, 2023 •
edited
Loading

update: taking opportunity to apply a less strict semver in tonic_lnd dependency so we can just keep rolling on the patch version

@okjodom
Copy link
Collaborator Author

okjodom commented Oct 24, 2023

update: cargo update to fetch the latest version of fedimint-tonic-lnd, now available in crates.io

@okjodom
Copy link
Collaborator Author

okjodom commented Oct 24, 2023

update: avoided cargo update in favor of more atomic version bump :p

sr-gi
sr-gi approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@sr-gi sr-gi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK bcd3b2f

carlaKC
carlaKC approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@carlaKC carlaKC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, only briefly reviewed the upstream change but it lgtm!

@carlaKC
Copy link
Contributor

carlaKC commented Oct 25, 2023

Would be nice to tack on a change to the readme that has IPs because it's still pretty odd to need https://ip address - either push with this PR or in a followup, I'm easy.

@carlaKC carlaKC mentioned this pull request Oct 25, 2023
Closed
@okjodom
Copy link
Collaborator Author

okjodom commented Oct 25, 2023

Would be nice to tack on a change to the readme that has IPs because it's still pretty odd to need https://ip address - either push with this PR or in a followup, I'm easy.

appended in readme with ip/domain addresses in examples. we always need https for these tls connections.

carlaKC
carlaKC approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@carlaKC carlaKC left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@carlaKC carlaKC merged commit f9d8541 into bitcoin-dev-project:main Oct 25, 2023
2 checks passed
@pinheadmz pinheadmz mentioned this pull request Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlaKC carlaKC carlaKC approved these changes

@sr-gi sr-gi sr-gi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@okjodom @carlaKC @sr-gi