patch: support IP address connections to LND nodes #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It may be worth waiting for the PR to be merged. It LGTM, but just in case things can be improved. If it takes too long, then we can just merge it. Really nice work! |
carlaKC
reviewed
Oct 23, 2023
There was a problem hiding this comment.
tACK 🎉
It may be worth waiting for the PR to be merged. It LGTM, but just in case things can be improved. If it takes too long, then we can just merge it.
Agree here! If it's going to take > 1 week happy to point to the branch, not difficult to come back and update the dep.
|
closing in favor of #151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch uses an updated version of fedimint-tonic-lnd that supports IP address connections to LND nodes.