-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support changing default node/background color #143
Comments
Whatever default we select, we should make both background color and tree color user-selectable. |
Agreed, having both selectable will be really nice. Just for reference, here's what a "dark mode" tree looks like in Empress ;) -- I imagine sticking with the black/gray on white default will be preferred by most users, but supporting this stuff (and #137) will make it really easy to style Emperor and Empress similarly. |
Related to how we want to represent non-unique and non-represented features. |
One complication with this issue is that, if we change the default node color to black (which I think would be best IMO), then the root node's special black marker no longer stands out: I think the way around this is changing the root's marker to be different in some other way (e.g. a square / star / unfilled circle / etc.), and maybe making the color of the root configurable as well. |
A different shape should work well 👍 |
(Next up is making the default node color, and the background color, configurable.)
Did a bit more looking into this; it looks like Emperor uses Spectrum for letting users select colors, so I think for the sake of simplicity it would be good to just use that for this. (I'd thought it might be possible for us to re-use the vendor JS code between Emperor and Empress in the tandem plots -- letting us avoid duplicating the files unnecessarily -- but it doesn't look like that is currently possible, and I suspect that would probably be more trouble than it's worth.) |
This messes with a few things (1. emperor's spectrum css, 2. with any coloring done to the tree before changing the colors), and I think the default node color is being used elsewhere... so this is an early version of this. Still promising, though!
Update: plan as I understand it for now is having the background color changing be part of the second alpha release, and having the default node color changing be part of a later release.
Just a small thing that would be nice in the future. For example, drawing nodes black (rather than with the default gray color currently used) increases the contrast significantly:
This could be useful for e.g. vision-impaired folks.
Might be a nice TODO at some point down the line after #137?
The text was updated successfully, but these errors were encountered: