Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set root marker to a non-circle shape, and allow recoloring based on root node's color #211

Closed
fedarko opened this issue Jun 25, 2020 · 2 comments

Comments

@fedarko
Copy link
Collaborator

fedarko commented Jun 25, 2020

  1. Justification for the "shape" thing is described in detail in the thread starting here. Making this its own issue so I don't forget about that :)

  2. Regarding the "recoloring" thing: this is due to a very minor issue that I doubt most users will run into. When the root node has a unique color (i.e. when coloring by feature metadata using both internal node / tip metadata, and the root has a unique value for the selected feature metadata field), this color is included in the legend as expected:

image

However, the only layout that actually draws anything besides the marker for the root node is the rectangular layout. In the circular and unrooted layout, no lines for the root node are drawn, and therefore the entry in the legend for the root node's unique color goes unused in the tree. This could confuse users:

image

A way around this issue would be no longer coloring the root marker black, but instead allowing its color to change based on its node color (ensuring that the root node's unique color in the legend is actually reflected somewhere in the tree).

@ElDeveloper
Copy link
Member

A way around this issue would be no longer coloring the root marker black, but instead allowing its color to change based on its node color (ensuring that the root node's unique color in the legend is actually reflected somewhere in the tree).

Interested in what others think but this sounds like a good option.

@kwcantrell
Copy link
Collaborator

I agree, we should change the root marker to a special shape and allow its color to change based on its node color. This would allow the user to still visually see the root as well as resolve the legend issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants