Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Extract graphs from impact page #585

Merged
merged 8 commits into from
Dec 6, 2024
Merged

Conversation

iamdamion
Copy link
Contributor

@iamdamion iamdamion commented Dec 5, 2024

made dashboards section a new page.

Screen Shot 2024-12-05 at 9 15 00 AM
Screen Shot 2024-12-05 at 9 16 20 AM

@christinerogers
Copy link
Contributor

christinerogers commented Dec 5, 2024

  • change page title Dashboards : Measuring BIDS Impact
  • for the Gender of contributors, add as of June 2024

looks good

Co-authored-by: Anthony Galassi <[email protected]>
docs/impact/dashboards.md Outdated Show resolved Hide resolved
mkdocs.yml Outdated
@@ -169,6 +169,7 @@ nav:
- Using MkDocs macros: extensions/macros_doc.md
- Impact:
- impact/index.md
- impact/dashboards.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- impact/dashboards.md
- impact/measuring_BIDS_impact.md

Rename to make rendering/reading of markdown yaml more clear later.

Copy link
Contributor

@bendhouseart bendhouseart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to remove/change first heading/title, requested changes added with code suggestions/comments.

@Remi-Gau
Copy link
Contributor

Remi-Gau commented Dec 5, 2024

  • for the Gender of contributors, add as of June 2024

Will do that in a follow up PR to make sure this is automatically updated when recount this when we have new contributors.

@Remi-Gau Remi-Gau changed the title second pass impact page [ENH] Extract graphs from impact page Dec 6, 2024
@Remi-Gau Remi-Gau merged commit 53e3859 into main Dec 6, 2024
7 of 8 checks passed
@Remi-Gau Remi-Gau deleted the 550-impact-second-pass branch December 6, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants