Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom gyro defines when align preset is used #673

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Remove custom gyro defines when align preset is used #673

merged 1 commit into from
Jan 21, 2025

Conversation

haslinghuis
Copy link
Member

  • As most configs were migrated from unified targets - cli contains values for gyro align preset and custom alignment results.
  • Removing custom alignment where preset is present

@haslinghuis haslinghuis mentioned this pull request Jan 21, 2025
Merged
nerdCopter
nerdCopter approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving untested

ledvinap
ledvinap approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@ledvinap ledvinap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC GYRO_n_ALIGN did override rpy, so this should be pretty safe.
but i don't understand what caused this mismatch.

@haslinghuis haslinghuis merged commit 3f3dd34 into betaflight:master Jan 21, 2025
1 check passed
@haslinghuis haslinghuis mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ledvinap ledvinap ledvinap approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@ot0tot ot0tot Awaiting requested review from ot0tot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haslinghuis @ledvinap @nerdCopter