Make LazyAssertion open for extension #285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rquadling
reviewed
Aug 31, 2019
| /** @var string */ | ||
| protected static $lazyAssertionClass = LazyAssertion::class; | ||
|
|
||
| public static function that($value, $defaultMessage = null, $defaultPropertyPath = null, array $context = []) |
There was a problem hiding this comment.
This line generates an appropriate error when running static analysis.
$ composer assert:sa-tests
> vendor/bin/phpstan analyse --configuration=phpstan-tests.neon --no-progress --ansi -l 7 tests
Fatal error: Declaration of Assert\Tests\Fixtures\ContextAware\Assert::that($value, $defaultMessage = NULL, string $defaultPropertyPath = NULL, array $context = Array) must be compatible with Assert\Assert::that($value, $defaultMessage = NULL, string $defaultPropertyPath = NULL): Assert\AssertionChain in /Users/richardquadling/dev/php/beberlei/tests/Assert/Tests/Fixtures/ContextAware/Assert.php on line 19
PHP Fatal error: Declaration of Assert\Tests\Fixtures\ContextAware\Assert::that($value, $defaultMessage = NULL, string $defaultPropertyPath = NULL, array $context = Array) must be compatible with Assert\Assert::that($value, $defaultMessage = NULL, string $defaultPropertyPath = NULL): Assert\AssertionChain in /Users/richardquadling/dev/php/beberlei/tests/Assert/Tests/Fixtures/ContextAware/Assert.php on line 19
Script vendor/bin/phpstan analyse --configuration=phpstan-tests.neon --no-progress --ansi -l 7 tests handling the assert:sa-tests event returned with error code 255
rquadling
reviewed
Aug 31, 2019
| use Assert\Tests\Fixtures\ContextAware\LazyAssertion; | ||
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| class ContextAwareLazyAssertion extends TestCase |
There was a problem hiding this comment.
As this class does not have Test in the name, it is not run by PHPUnit. Renaming it to ContextAwareLazyAssertionTest, reveals the error found by static analysis.
DannyvdSluijs
force-pushed
the
feature/make-lazy-assertion-open-for-extension
branch
from
49aef74 to
d6d2e8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.