Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GHA extract shell scripts action #1

Merged
merged 11 commits into from
Jan 6, 2025
Merged

Create GHA extract shell scripts action #1

merged 11 commits into from
Jan 6, 2025

Conversation

omus
Copy link
Member

@omus omus commented Dec 17, 2024

Implements the action. A future improvement that could be made would be to lint action.yaml files.

@omus omus marked this pull request as ready for review December 18, 2024 21:21
@omus omus requested a review from kleinschmidt December 18, 2024 21:21
@omus omus force-pushed the cv/initial branch 2 times, most recently from bdc61a8 to 71bb7cc Compare December 18, 2024 22:06
Copy link

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In integration-tests.yaml/job=Test/step=Test_extracted.sh line 17:
echo $foo
     ^--^ SC2154 (warning): foo is referenced but not assigned.
     ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
echo "$foo"

For more information:
  https://www.shellcheck.net/wiki/SC2154 -- foo is referenced but not assigned.
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.



shfmt errors
'shfmt ' found no issues.

test/github-actions-demo.yaml Show resolved Hide resolved
@omus omus merged commit a9e3b70 into main Jan 6, 2025
3 checks passed
@omus omus deleted the cv/initial branch January 6, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants