Expressions in GHA env variables are purposefully not expanded

beacon-biosignals · Dec 18, 2024 · 6dca3db · 6dca3db
1 parent 49450bc
commit 6dca3db
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/integration-tests.yaml b/.github/workflows/integration-tests.yaml
@@ -42,9 +42,9 @@ jobs:
           expected: |-
             #!/usr/bin/env bash
             set -e
-            # shellcheck disable=SC2034
+            # shellcheck disable=SC2016,SC2034
             greeting='Hello'
-            # shellcheck disable=SC2034
+            # shellcheck disable=SC2016,SC2034
             name='Integration Tests'
             # ---
             echo ":env.greeting:, $name"
diff --git a/gha_extract_shell_scripts.py b/gha_extract_shell_scripts.py
@@ -90,7 +90,7 @@ def process_workflow_file(workflow_path: Path, output_dir: Path, ignored_errors=
                 elif shell == "bash":
                     f.write("set -eo pipefail\n")
                 for k, v in env.items():
-                    f.write("# shellcheck disable=SC2034\n")
+                    f.write("# shellcheck disable=SC2016,SC2034\n")
                     v = sanitize_gha_expression(str(v)).replace("'", "'\\''")
                     f.write(f"{k}='{v}'\n")
                 f.write("# ---\n")