Add generalized methods #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still on draft until I'm done with unit tests. |
Signed-off-by: Michel Hidalgo <[email protected]>
mhidalgo-bdai
force-pushed
the
mhidalgo-bdai/generalized-methods
branch
from
3cdfb32 to
bb32b10
Compare
Signed-off-by: Michel Hidalgo <[email protected]>
|
Tests added. Ready for review! |
Signed-off-by: Michel Hidalgo <[email protected]>
|
|
||
|
|
||
| @overload | ||
| def generalizedmethod(func: Callable, *, transitional: bool = ...) -> GeneralizedMethod: |
There was a problem hiding this comment.
Suggested change
| def generalizedmethod(func: Callable, *, transitional: bool = ...) -> GeneralizedMethod: | |
| def generalized_method(func: Callable, *, transitional: bool = ...) -> GeneralizedMethod: |
There was a problem hiding this comment.
Done in 8fbf659.
Signed-off-by: Michel Hidalgo <[email protected]>
amessing-bdai
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch builds on top of #92 to introduce generalized methods, functions bound to class instances. This restores user facing type annotations and docstrings for generalized callables used in class (or mixin 👀) context.