Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMA-362: Natspec FIx #177

Merged
merged 1 commit into from
Nov 30, 2023
Merged

SMA-362: Natspec FIx #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions contracts/smart-account/interfaces/modules/IMultiOwnedECDSAModule.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,14 @@
pragma solidity ^0.8.20;

/**
* @title ECDSA ownership Authorization module for Biconomy Smart Accounts.
* @title ECDSA Multi Ownership Authorization Module for Biconomy Smart Accounts.
* @dev Compatible with Biconomy Modular Interface v 0.1
* - It allows to validate user operations signed by EOA private key.
* - EIP-1271 compatible (ensures Smart Account can validate signed messages).
* - One owner per Smart Account.
* - Multiple owners per Smart Account.
* - Does not support outdated eth_sign flow for cheaper validations
* (see https://support.metamask.io/hc/en-us/articles/14764161421467-What-is-eth-sign-and-why-is-it-a-risk-)
* !!!!!!! Only EOA owners supported, no Smart Account Owners
* For Smart Contract Owners check SmartContractOwnership module instead
* @author Fil Makarov - <[email protected]>
*/
interface IMultiOwnedECDSAModule {
Expand Down
5 changes: 2 additions & 3 deletions contracts/smart-account/modules/MultiOwnedECDSAModule.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,14 @@ import {IAuthorizationModule} from "../interfaces/IAuthorizationModule.sol";
import {ISignatureValidator} from "../interfaces/ISignatureValidator.sol";

/**
* @title ECDSA ownership Authorization module for Biconomy Smart Accounts.
* @title ECDSA Multi Ownership Authorization Module for Biconomy Smart Accounts.
* @dev Compatible with Biconomy Modular Interface v 0.1
* - It allows to validate user operations signed by EOA private key.
* - EIP-1271 compatible (ensures Smart Account can validate signed messages).
* - One owner per Smart Account.
* - Multiple owners per Smart Account.
* - Does not support outdated eth_sign flow for cheaper validations
* (see https://support.metamask.io/hc/en-us/articles/14764161421467-What-is-eth-sign-and-why-is-it-a-risk-)
* !!!!!!! Only EOA owners supported, no Smart Account Owners
* For Smart Contract Owners check SmartContractOwnership module instead
* @author Fil Makarov - <[email protected]>
*/

Expand Down