Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMA-362: Natspec FIx #177

Merged
merged 1 commit into from
Nov 30, 2023
Merged

SMA-362: Natspec FIx #177

merged 1 commit into from
Nov 30, 2023

Conversation

ankurdubey521
Copy link
Contributor

Summary

Fixes #156

Related Issue: # (issue number)

Change Type

  • Bug Fix
  • Refactor
  • New Feature
  • Breaking Change
  • Documentation Update
  • Performance Improvement
  • Other

Checklist

  • My code follows this project's style guidelines
  • I've reviewed my own code
  • I've added comments for any hard-to-understand areas
  • I've updated the documentation if necessary
  • My changes generate no new warnings
  • I've added tests that prove my fix is effective or my feature works
  • All unit tests pass locally with my changes
  • Any dependent changes have been merged and published

@ankurdubey521 ankurdubey521 added the documentation Improvements or additions to documentation label Nov 29, 2023
@ankurdubey521 ankurdubey521 self-assigned this Nov 29, 2023
@linear Linear
Copy link

linear bot commented Nov 29, 2023

SMA-362 Wrong information in natspec #156

#156

@ankurdubey521 ankurdubey521 changed the title fix: MultiOwnedECDSAModule natspec SMA-362: Natspec FIx Nov 29, 2023
livingrockrises
livingrockrises approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@livingrockrises livingrockrises left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@livingrockrises livingrockrises merged commit b4d539d into develop Nov 30, 2023
2 checks passed
@filmakarov filmakarov deleted the feat/sma-362-multi-owned-ecdsa-natspec-fix branch January 16, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmanRaj1608 AmanRaj1608 AmanRaj1608 approved these changes

@livingrockrises livingrockrises livingrockrises approved these changes

@filmakarov filmakarov Awaiting requested review from filmakarov

@Aboudjem Aboudjem Awaiting requested review from Aboudjem

Assignees

@ankurdubey521 ankurdubey521

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ankurdubey521 @AmanRaj1608 @livingrockrises