Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DESENG-496: Fixed Comments cannot be approved #2398

Merged
merged 2 commits into from
Feb 28, 2024
Merged

DESENG-496: Fixed Comments cannot be approved #2398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c23bfc
DESENG-496: Fixed Comments cannot be approved
ratheesh-aot Feb 28, 2024
4fcf9a8
Merge remote-tracking branch 'upstream/main' into DESENG-496-Comments
ratheesh-aot Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.MD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
## February 27, 2024
- **Bug Fix**Comments cannot be approved while reviewing [DESENG-496](https://apps.itsm.gov.bc.ca/jira/browse/DESENG-496)
- Fixed by adding a missing decorator for transactional methods.
- **Task**Enhance analytics api for Improved Readability and Maintainability [DESENG-492](https://apps.itsm.gov.bc.ca/jira/browse/DESENG-492)
- Refactor analytics-api config to harmonize its structure and conventions with met-api.
- Ensure the sample.env file maintains consistent formatting.
Expand Down
1 change: 1 addition & 0 deletions met-api/src/met_api/services/submission_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ def _validate_fields(submission):
raise ValueError('Engagement not open to submissions')

@classmethod
@transactional()
ratheesh-aot marked this conversation as resolved.
Show resolved Hide resolved
def review_comment(cls, submission_id, staff_review_details: dict, external_user_id) -> SubmissionSchema:
"""Review comment."""
user = StaffUserService.get_user_by_external_id(external_user_id)
Expand Down
Loading