Feature/gofmt

.bazelci/presubmit.yml

@@ -2,6 +2,9 @@
 validate_config: 1
 tasks:
   ubuntu1804:
+      shell_commands:
+          - "echo +++ Check go format"
+          - "./check-gofmt.sh `find go -name '*.go'`"
       build_targets:
           - "//..."
       test_targets:

.githooks/pre-commit

@@ -0,0 +1,11 @@
+#!/bin/sh
+
+
+########################################################################
+# Check that all Go files have been gofmt'd.
+########################################################################
+# Find all change go files.
+gofiles=$(git diff --cached --name-only --diff-filter=ACM | grep '\.go$')
+[ -z "$gofiles" ] && exit 0
+
+source ./check-gofmt.sh "$gofiles"

check-gofmt.sh

@@ -0,0 +1,15 @@
+#!/bin/bash
+
+# Source: https://golang.org/misc/git/pre-commit
+
+unformatted=$(gofmt -l "$@")
+[ -z "$unformatted" ] && exit 0
+
+# Some files are not gofmt'd. Print message and fail.
+
+echo >&2 "Go files must be formatted with gofmt. Please run:"
+for fn in $unformatted; do
+	echo >&2 "  gofmt -w $PWD/$fn"
+done
+
+exit 1

setup-githooks.sh

@@ -0,0 +1,8 @@
+#!/bin/bash
+
+# Copies git hooks from .githooks/ to .git/hooks/, overriding any hooks you may
+# have previously had there.
+cp .githooks/* .git/hooks/
+for h in `ls .githooks/* | xargs basename`; do
+  chmod ug+x .git/hooks/$h
+done