Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gofmt #64

Merged
merged 7 commits into from
Jul 26, 2019
Merged

Feature/gofmt #64

merged 7 commits into from
Jul 26, 2019

Conversation

ifoox
Copy link
Collaborator

@ifoox ifoox commented Jul 25, 2019

Add got pre-commit hook and buildkite CI pre-commit check for go fmt.

Note the CI presubmit hook currently checks all go files under go/ since it didn't seem trivial to figure out the merge base branch that the pull request is against so that we can compute the files changed between the current branch and that branch. We can always add this later.

Part way towards #53

@googlebot googlebot added the cla: yes The author signed a CLA label Jul 25, 2019
@ifoox ifoox requested a review from ola-rozenfeld July 25, 2019 19:33
@ifoox
Copy link
Collaborator Author

ifoox commented Jul 25, 2019

You can see an example of this failing on 7b691f7 where I modified a go file (and made this check actually work) and then succeeding on 6064431 where I reverted the go file change.

Copy link
Contributor

@ola-rozenfeld ola-rozenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this doesn't close the bug, because the bug also referred to golint, not just go fmt.

@ifoox
Copy link
Collaborator Author

ifoox commented Jul 26, 2019

Thanks for the review, missed the lint part on first reading, will add that in a later pass.

@ifoox ifoox merged commit 2507bf2 into bazelbuild:master Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes The author signed a CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants