Extend depth overlay tests to include shader exported depth #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zorro666
deleted the
support-shader-exported-depth-in-depth-test-overlay
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend the depth overlay tests to support Issue 2858
This is the final PR in the sequence of PRs which all together complete the implementation of the feature.
This final PR extends the automated overlay tests
GL_Overlay_Test,D3D11_Overlay_Test,D3D12_Overlay_Test,VK_Overlay_Test. The tests have been extended to use a pixel shader to write out depth 0.0 for a small rectangle just bottom-left of the centre.This also includes a minor tweak to the D3D12 overlay initialisation code based on a compile error from clang on similar code used in the Vulkan overlay initialisation.
Testing
GL_Overlay_Test,D3D11_Overlay_Test,D3D12_Overlay_Test,VK_Overlay_Test.GL_Overlay_Test,VK_Overlay_Test.